Alona Kaplan has uploaded a new change for review.

Change subject: engine: fix VdcOptionDAOTest.testGetWithInvalidId
......................................................................

engine: fix VdcOptionDAOTest.testGetWithInvalidId

The max configValue id exceeded 717,
changed the "INVALID_ID' in the test to -1, it is for sure invalid.

Change-Id: I0ec8215ec8128a873b6e76709842d9bacbf3fbf7
Signed-off-by: Alona Kaplan <[email protected]>
---
M 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/39051/1

diff --git 
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java
 
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java
index 696028b..0aa8f25 100644
--- 
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java
+++ 
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java
@@ -11,6 +11,7 @@
 import org.ovirt.engine.core.common.businessentities.VdcOption;
 
 public class VdcOptionDAOTest extends BaseDAOTestCase {
+    private static final int INVALID_ID = -1;
     private static final int OPTION_COUNT = 8;
     private VdcOptionDAO dao;
     private VdcOption existingOption;
@@ -35,7 +36,7 @@
      */
     @Test
     public void testGetWithInvalidId() {
-        VdcOption result = dao.get(717);
+        VdcOption result = dao.get(INVALID_ID);
 
         assertNull(result);
     }


-- 
To view, visit https://gerrit.ovirt.org/39051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ec8215ec8128a873b6e76709842d9bacbf3fbf7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to