Juan Hernandez has posted comments on this change.
Change subject: restapi: Phase 5: Add graphics console representation
......................................................................
Patch Set 1:
If I understand correctly this will introduced a list of "graphics_consoles"
inside the representation of the VM, something like this:
GET /vms/{vm:id}
<vm>
<display>
<graphics_consoles>
<graphics_console>...</graphics_console>
...
</graphics_consoles>
...
</display>
...
</vm>
Then a follow up patch (phase 5: Retrive console descriptor file) will
introduce a kind of sub-resource (actually just a method) to retrieve the .vv
file:
GET /vm/{vm:id}/display/graphicsconsoles/{graphicsconsole:id}
Accept: application/x-virt-viewer
...
These two mechanisms aren't consistent and won't be supported by the SDKs or
the CLI. I think that the "graphics consoles" should be a sub-collection of the
VM:
GET /vms/{vm:id}/graphicsconsoles
<graphics_consoles>
<graphics_console>...</graphics_console>
...
</graphics_consoles>
This will allow for adding, updating and removing them (not necessarily now,
but maybe in the future).
The operation to get the .vv file should then just be the @GET method (with the
.vv content type) of one of the resources of this collection:
GET /vms/{vm:id}/graphicsconsoles/{graphicsconsole:id}
Accept: application/x-virt-viewer
--
To view, visit https://gerrit.ovirt.org/39057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dbc63ac49bfba5637c38b84b373d78f348c7872
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
