Moti Asayag has posted comments on this change. Change subject: jsonrpc: two way heartbeats ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38003/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 463: } Line 464: Line 465: private void updateHeartbeatPolicy(boolean isHeartbeat) { Line 466: RetryPolicy policy = client.getClientRetryPolicy(); Line 467: policy.setIncomingHeartbeat(isHeartbeat); jenkins complains about those 2 methods. were they introduced in vdsm-jsonrpc-java 1.1.0-SNAPSHOT ? Line 468: policy.setOutgoingHeartbeat(isHeartbeat); Line 469: client.setClientRetryPolicy(policy); Line 470: } Line 471: -- To view, visit https://gerrit.ovirt.org/38003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c903a20f3bc97b9b1665fd69f7dd840bb62672 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Eldad Marciano <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: eldad marciano <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
