Mike Kolesnik has uploaded a new change for review. Change subject: core: Improve VmDevice's toString (#851991) ......................................................................
core: Improve VmDevice's toString (#851991) https://bugzilla.redhat.com/851991 1. Improved VmDevice's to string to print the field names. 2. Added enclosing brackets. 3. Added spacing between field names. Change-Id: I35434973e5cc9fe4f06d35b1b24afdfca484f6dc Signed-off-by: Mike Kolesnik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/7875/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java index 7821c5a..12bcbd2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java @@ -275,29 +275,30 @@ @Override public String toString() { - StringBuilder sb = new StringBuilder(); - sb.append("VmId="); + StringBuilder sb = new StringBuilder("VmDevice {"); + sb.append("vmId="); sb.append(id.getVmId()); - sb.append(",DeviceId="); + sb.append(", deviceId="); sb.append(id.getDeviceId()); - sb.append(",Device="); + sb.append(", device="); sb.append(getDevice()); - sb.append(",Type="); + sb.append(", type="); sb.append(getType()); - sb.append(",BootOrder="); + sb.append(", bootOrder="); sb.append(getBootOrder()); - sb.append(",SpecParams="); + sb.append(", specParams="); sb.append(getSpecParams()); - sb.append(",Address="); + sb.append(", address="); sb.append(getAddress()); - sb.append(",IsManaged="); + sb.append(", managed="); sb.append(getIsManaged()); - sb.append(",IsPlugged="); + sb.append(", plugged="); sb.append(getIsPlugged()); - sb.append(",IsReadOnly="); + sb.append(", readOnly="); sb.append(getIsReadOnly()); - sb.append(",alias="); + sb.append(", alias="); sb.append(getAlias()); + sb.append("}"); return sb.toString(); } } -- To view, visit http://gerrit.ovirt.org/7875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35434973e5cc9fe4f06d35b1b24afdfca484f6dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
