Moti Asayag has posted comments on this change.
Change subject: core: Do Not Fail RunVm on Non-Activated Vnic (#854978)
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 327: return readyToRun.isEmpty() ? Guid.Empty :
getBestVdsToRun(readyToRun);
Line 328: }
Line 329:
Line 330: /**
Line 331: * Determine whether all required networks are assigned to the
VDS's nics. Required networks are the networks that
s/assigned/attached
Line 332: * are defined on active vnics of the VM.
Line 333: *
Line 334: * @param vdsId
Line 335: * The VDS id.
Line 332: * are defined on active vnics of the VM.
Line 333: *
Line 334: * @param vdsId
Line 335: * The VDS id.
Line 336: * @return <c>true</c> if all required networks are assigned to a
host nic, otherwise, <c>false</c>.
s/assigned/attached
Line 337: */
Line 338: boolean areRequiredNetworksAvailable(Guid vdsId) {
Line 339: final List<VdsNetworkInterface> allInterfacesForVds =
getInterfaceDAO().getAllInterfacesForVds(vdsId);
Line 340: for (final VmNetworkInterface vmIf : getVmNICs()) {
--
To view, visit http://gerrit.ovirt.org/7878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1834acde0800562b653ba19648f5b8a1fa64733b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
