Moti Asayag has posted comments on this change. Change subject: engine: Validate change to gluster network ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/38177/11/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java: Line 151: when(oldNetworkCluster.isGluster()).thenReturn(glusterNetworkBefore); Line 152: when(networkCluster.isGluster()).thenReturn(glusterNetworkAfter); Line 153: when(cluster.supportsGlusterService()).thenReturn(glusterService); Line 154: doReturn(brickDao).when(validator).getGlusterBrickDao(); Line 155: ArrayList<GlusterBrickEntity> list = new ArrayList<>(); please replace 'list' with a meaningful name, also reduce the type of list to 'List'. Line 156: if (hasBricks) { Line 157: list.add(mock(GlusterBrickEntity.class)); Line 158: } Line 159: when(brickDao.getAllByClusterAndNetworkId(any(Guid.class), any(Guid.class))).thenReturn(list); -- To view, visit https://gerrit.ovirt.org/38177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57398b39783dbdc5ae9f79e7d32794f416c23116 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
