Allon Mureinik has posted comments on this change.
Change subject: core,webadmin: Edit SD - applicable only from SPM (#846765)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
please remove the uneeded comment (see inline).
Also, what happens if there is no SPM currently selected?
Will returning a singleton list with null not cause an NPE in the model
somewhere?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
Line 118: * @return the map where the key is true/false value which means
if connection successes/not successes and value is
Line 119: * map of luns Ids -> connected hosts
Line 120: */
Line 121: private Pair<Boolean, Map<String, List<Guid>>>
ConnectVdsToLun(List<LUNs> luns) {
Line 122: // all vdss in pool except spm (already connected)
Please remove this comment too - it is no longer true after removing the if
block.
Line 123: Map<String, List<Guid>> resultMap = new HashMap<String,
List<Guid>>();
Line 124: for (VDS vds : getAllRunningVdssInPool()) {
Line 125: // try to connect vds to luns and getDeviceList in order
to refresh them
Line 126: for (LUNs lun : luns) {
--
To view, visit http://gerrit.ovirt.org/7882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5a87c07197e1297c30ef346caea3293304b4452
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
