Martin Peřina has posted comments on this change. Change subject: core: FenceVdsVDSCommand code cleanup ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38060/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java: Line 120: */ Line 121: private boolean isAlreadyInRequestedStatus() { Line 122: boolean ret = false; Line 123: FenceActionType action = getParameters().getAction(); Line 124: _result = fenceNode(FenceActionType.STATUS); > while at it, can you rename and remove the _ ? Removed in later patch Line 125: if (_result.power != null) { Line 126: String powerStatus = _result.power.toLowerCase(); Line 127: if ((action == FenceActionType.START && powerStatus.equals("on")) || Line 128: action == FenceActionType.STOP && powerStatus.equals("off")) -- To view, visit https://gerrit.ovirt.org/38060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I480f03acf41d53e90c3c0da6725523d0578adb52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
