Martin Peřina has posted comments on this change. Change subject: core: Introduce FenceAgentExecutor ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38063/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java: Line 185: Line 186: /** Line 187: * Creates a map of sanlock host ids per storage domain Line 188: */ Line 189: protected Map<Guid, Integer> createStorageDomainHostIdMap() { > Now I seriously have deja vu. Yes, this method is here and in FenceExecutor class, but as I said before FenceExecutor class will be removed in the last patch of the serie. Line 190: Map<Guid, Integer> map = null; Line 191: if (fencingPolicy.isSkipFencingIfSDActive()) { Line 192: map = new HashMap<>(); Line 193: -- To view, visit https://gerrit.ovirt.org/38063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10936f4bc6a3b824a10a7ebc39de1f3a48eb778e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
