Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: generate cloud-init ISO image ......................................................................
Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38811/9/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 99: interactive = { Line 100: self.environment[ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO], Line 101: self.environment[ohostedcons.VMEnv.CLOUD_INIT_ROOTPWD], Line 102: self.environment[ohostedcons.VMEnv.CLOUD_INIT_INSTANCE_HOSTNAME], Line 103: } == {None} Even nicer :-) I never use '{}' for sets, I guess it's because python prints a set as set([list]), not sure why. Line 104: Line 105: if interactive: Line 106: if self.dialog.queryString( Line 107: name='CLOUD_INIT_USE', -- To view, visit https://gerrit.ovirt.org/38811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
