Alona Kaplan has posted comments on this change. Change subject: engine: add management net validation on host move to another cluster ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39183/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java: Line 177: private boolean isSameManagementNetwork() { Line 178: final Network sourceManagementNetwork = getNetworkDao().getManagementNetwork(getSourceCluster().getId()); Line 179: final Network targetManagementNetwork = getNetworkDao().getManagementNetwork(getTargetCluster().getId()); Line 180: Line 181: return targetManagementNetwork != null IIUC, moving to a cluster from a different dc is allowed if it contains network with the same name (the nic-network will be marked as unsync if the vlan or mtu are different). Please make sure this behavior will remain when moving to the new networking api (IIRC, it compares networks via id and not name, which can cause the old mgmt host-network to be unmanaged and the host to remain without a cluster management network). Line 182: && sourceManagementNetwork.getName().equals(targetManagementNetwork.getName()); Line 183: } Line 184: Line 185: private boolean hostHasLabeledNics() { -- To view, visit https://gerrit.ovirt.org/39183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef330309ccc90142c8734454ddcf6f2f3587abc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
