Gilad Chaplik has posted comments on this change.
Change subject: UI: when no tasks avilable dont show empty string (#854169)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java
Line 10:
Line 11: public class TaskFirstRowModelProvider extends TaskModelProvider {
Line 12:
Line 13: private static Job emptyJob = new Job();
Line 14: private static String emptyJobMessage = "[No jobs available]";
//$NON-NLS-1$
should be localized :))
Line 15: static {
Line 16: emptyJob.setDescription(emptyJobMessage);
Line 17: }
Line 18:
Line 22: }
Line 23:
Line 24: @Override
Line 25: protected void updateDataProvider(List<Job> items) {
Line 26: List<Job> firstRowData = items.isEmpty() ?
Arrays.asList(emptyJob) : Arrays.asList(items.get(0));
why the array isn't static as well?
Line 27: super.updateDataProvider(firstRowData);
Line 28: }
Line 29:
--
To view, visit http://gerrit.ovirt.org/7924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d48ff3bff032f31f3fb5e70637dd11e401153d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
