Moti Asayag has posted comments on this change. Change subject: engine: Replace CacheWrapper with plain Map ......................................................................
Patch Set 3: Answering both Ravi and Yair: Regarding using Map - if we'd require additional functionally from Map interface, it means same functionality should be provided by the future cache mechanism. I don't think we should plan a head internal optimization which has not been discussed/designed and not to decide a head on API which might not fulfil all of the needs. There is no risk in not determine an API at the moment, since this is internally only and doesn't break any backward compatibility. For instance, the entire CacheProviderFactory is redundant in case we decide to go with JCache and JCacheFactory. Based on the above i suggest to merge this patch, and re-evaluate alternatives when it will be need. -- To view, visit https://gerrit.ovirt.org/38698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fc00faa1e71a43b544cadd8f825c06799ec1154 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
