Sandro Bonazzola has posted comments on this change.

Change subject: hosted-engine: allow to deploy hosted-engine
......................................................................


Patch Set 14:

(2 comments)

https://gerrit.ovirt.org/#/c/38547/14/ovirt-host-deploy-offline.spec.in
File ovirt-host-deploy-offline.spec.in:

Line 36: Requires:      tar
Line 37: Requires:      tuned
Line 38: Requires:      util-linux
Line 39: Requires:      ovirt-hosted-engine-ha
Line 40: Requires:      ovirt-hosted-engine-setup
> Need to discuss this with some people but I think it's in the plan.
Changed to be required on x86_64 only
Line 41: Requires:      vdsm
Line 42: Requires:      vdsm-cli
Line 43: %ifarch %{ix86} x86_64
Line 44: Requires:      dmidecode


https://gerrit.ovirt.org/#/c/38547/14/src/plugins/ovirt-host-deploy/core/offlinepackager.py
File src/plugins/ovirt-host-deploy/core/offlinepackager.py:

Line 69:                     'release': '1',
Line 70:                     'epoch': '0',
Line 71:                     'arch': 'noarch',
Line 72:                 },
Line 73:             ]
> I'll remove
removed
Line 74:         elif tuple(patterns) == ('vdsm',):
Line 75:             return [
Line 76:                 {
Line 77:                     'operation': 'installed',


-- 
To view, visit https://gerrit.ovirt.org/38547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to