Maor Lipchuk has posted comments on this change.

Change subject: core: Add command to remove VM with Cinder disks
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/39228/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Adding a command for removing all the Cinder disks attached to a VM.
Line 10: 
Line 11: Change-Id: I5ed7ecdd6cd891936ed7a18b4f48eec48935b79a
Line 12: Bug-Url: https://bugzilla.redhat.com/??????
> add missing # or remove....
Done


https://gerrit.ovirt.org/#/c/39228/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java:

Line 427:     // Cinder
Line 428:     AddCinderDisk(3200, ActionGroup.CONFIGURE_VM_STORAGE, false, 
QuotaDependency.NONE),
Line 429:     RemoveCinderDisk(3201, QuotaDependency.STORAGE),
Line 430:     ExtendCinderDisk(3202, ActionGroup.CONFIGURE_VM_STORAGE, 
QuotaDependency.NONE),
Line 431:     RemoveAllVmCinderDisks(3203, ActionGroup.CONFIGURE_VM_STORAGE, 
false, QuotaDependency.NONE),
> remove 'false'. try using QuotaDependency.STORAGE.
Done
Line 432: 
Line 433:     // Host Devices
Line 434:     RefreshHostDevices(4000, ActionGroup.MANIPULATE_HOST, false, 
QuotaDependency.NONE);
Line 435: 


-- 
To view, visit https://gerrit.ovirt.org/39228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed7ecdd6cd891936ed7a18b4f48eec48935b79a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to