Tomas Jelinek has uploaded a new change for review. Change subject: userportal,webadmin: Run once: unable to attach floppy disks (#855579) ......................................................................
userportal,webadmin: Run once: unable to attach floppy disks (#855579) https://bugzilla.redhat.com/855579 The problem was, that the IsoDomainListSyncronizer. getUserRequestForStoragePoolAndDomainRepoFileList ignored the fileTypeExtension. Fixed by enriching the IsoDomainListSyncronizer.getCachedIsoListByStoragePoolAndDomainId by fileTypeExtension the same way as getCachedIsoListByDomainId is done. Change-Id: I11d2f7caf8f75efd83e3b557c9e305baebcef2ec Signed-off-by: Tomas Jelinek <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/7965/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java index 5927639..849ddc4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java @@ -189,7 +189,7 @@ return null; } // At any case, if refreshed or not, get Iso list from the cache. - repoList = getCachedIsoListByStoragePoolAndDomainId(storagePoolId, storageDomainId); + repoList = getCachedIsoListByStoragePoolAndDomainId(storagePoolId, storageDomainId, fileTypeExtension); // Return list of repository files. return repoList; @@ -376,13 +376,12 @@ * - The storage pool Id we want to get the file list from. * @return List of Iso file fetched from DB, if parameter is invalid returns an empty list. */ - public List<RepoFileMetaData> getCachedIsoListByStoragePoolAndDomainId(Guid isoStoragePoolId, Guid isoStorageDomainId) { + public List<RepoFileMetaData> getCachedIsoListByStoragePoolAndDomainId(Guid isoStoragePoolId, Guid isoStorageDomainId, FileTypeExtension fileTypeExtension) { List<RepoFileMetaData> fileListMD = new ArrayList<RepoFileMetaData>(); // Check validation of parameters. if (isoStorageDomainId != null && isoStoragePoolId != null && VmRunHandler.getInstance().findActiveISODomain(isoStoragePoolId) != null) { // Get all the Iso files of storage and domain ID. - fileListMD = repoStorageDom.getRepoListForStorageDomainAndStoragePool(isoStoragePoolId, isoStorageDomainId, - FileTypeExtension.ISO); + fileListMD = repoStorageDom.getRepoListForStorageDomainAndStoragePool(isoStoragePoolId, isoStorageDomainId, fileTypeExtension); } return fileListMD; } -- To view, visit http://gerrit.ovirt.org/7965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11d2f7caf8f75efd83e3b557c9e305baebcef2ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
