Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: pki: upgrade cert templates ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38644/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 183: if aia is not None: Line 184: localtransaction = transaction.Transaction() Line 185: with localtransaction: Line 186: for name in ( Line 187: oenginecons.FileLocations.OVIRT_ENGINE_PKI_CA_TEMPLATE, Why also CA template? Seems like it currently does not include @AIA@, so will be left untouched, but if in some future version it will, will we want to regenerate it on upgrade? Line 188: oenginecons.FileLocations.OVIRT_ENGINE_PKI_CERT_TEMPLATE, Line 189: ): Line 190: localtransaction.append( Line 191: filetransaction.FileTransaction( -- To view, visit https://gerrit.ovirt.org/38644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia975aad12e97ce0287cd6414e7ab91ea2ca6c0f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
