Allon Mureinik has posted comments on this change. Change subject: core: Renamed CanAddVm to canAddVm ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) See some comments about the commit message. Other than that - looks good. .................................................... Commit Message Line 3: AuthorDate: 2012-09-12 19:41:09 -0700 Line 4: Commit: Sharad Mishra <[email protected]> Line 5: CommitDate: 2012-09-12 19:46:30 -0700 Line 6: Line 7: core: Renamed CanAddVm to canAddVm please add the class name to the title too. Line 8: Line 9: This makes method name conform to java style. Line 10: Line 11: Change-Id: Id7a141ce3cf1be4215d34ec663cd8635fc709674 Line 5: CommitDate: 2012-09-12 19:46:30 -0700 Line 6: Line 7: core: Renamed CanAddVm to canAddVm Line 8: Line 9: This makes method name conform to java style. c/method/the method/ Line 10: Line 11: Change-Id: Id7a141ce3cf1be4215d34ec663cd8635fc709674 -- To view, visit http://gerrit.ovirt.org/7971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a141ce3cf1be4215d34ec663cd8635fc709674 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
