Eli Mesika has posted comments on this change. Change subject: core: fix the fn_db_split_config_value db function and uses ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/common_sp.sql Line 309: fetch v_cur into v_version; Line 310: exit when not found; Line 311: -- We shouldn't update if already exists Line 312: if (not exists (select 1 from vdc_options where option_name = v_option_name and version = v_version)) then Line 313: if (v_version >= v_update_from_version) then A potential bug can be here if you have for example version 3.1 3.2 to 3.10 then since all are strings 3.2 will be considered to be greater than 3.10 Line 314: insert into vdc_options (option_name, option_value, version) values (v_option_name, v_new_option_value, v_version); Line 315: else Line 316: insert into vdc_options (option_name, option_value, version) values (v_option_name, v_old_value, v_version); Line 317: end if; -- To view, visit http://gerrit.ovirt.org/7973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6964750ed0f57155e7c64a2a29ee0c21e2043410 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
