Piotr Kliczewski has posted comments on this change. Change subject: engine : Add json rpc request completed method ......................................................................
Patch Set 1: (1 comment) It looks like cool idea and you do not need to worry about having json client. When we migrate more commands to be asynchronous we will add additional methods in communication interface. For now it seems like good approach but we need to look for something more maintainable in the future. https://gerrit.ovirt.org/#/c/39373/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java: Line 85: return wrapper; Line 86: } Line 87: Line 88: @Override Line 89: public OneImageInfoReturnForXmlRpc getVolumeInfoAsync(String sdUUID, String spUUID, String imgGUID, String volUUID) { This wrapper represent xmlrpc. Maybe you could delegate to non-async method. Line 90: Map<String, Object> xmlRpcReturnValue = irsServer.getVolumeInfo(sdUUID, spUUID, imgGUID, volUUID); Line 91: OneImageInfoReturnForXmlRpc wrapper = new OneImageInfoReturnForXmlRpc(xmlRpcReturnValue); Line 92: return wrapper; Line 93: } -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e0ef961927c3fb17656ecac12d245c25b2ee367 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
