Greg Sheremeta has posted comments on this change. Change subject: webadmin : Fix Gluster only mode System tree ......................................................................
Patch Set 3: (1 comment) I need to study the code a bit more before giving a score. I'd appreciate Alexander and Vojtech's opinions on it. I'm not too familiar with the Tree. I'd also like Einav's opinion on whether it's an ok change to make. https://gerrit.ovirt.org/#/c/39363/3//COMMIT_MSG Commit Message: Line 7: webadmin : Fix Gluster only mode System tree Line 8: Line 9: This patch fixes the issue of System tree containing Line 10: only 2 entries System and Sessions. Line 11: This was happening as the filterSystemTreeByApplictionMode It took me a while to understand what this patch actually does, but I think I've got it now. In Gluster-only mode, there is no datacenter, but there are hosts and volumes. You're trying to make hosts and volumes show up in that case, right? So let's clean up this message a bit. I suggest a new first paragraph, something like: "This patch adds Hosts and Volumes nodes needed in Gluster-only mode to the System tree root. Previously only System and Sessions showed when in Gluster-only mode (because there is no datacenter in Gluster-only mode, and datacenter's children were being filtered out of the tree)." Line 12: of ApplicationModeHelper invoked by SystemTreeModel's Line 13: executed used to filter out(remove) the nodes in accordance Line 14: with ApplicationMode associated with nodes of SystemTree. Line 15: In Gluster's case , there isn't DataCenter node and hence -- To view, visit https://gerrit.ovirt.org/39363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c85bc2b78f885511a8e53212984d93343ffd6a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
