Juan Hernandez has posted comments on this change.
Change subject: core: Refactored roles to Role.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment inside.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java
Line 40: validateEnums(Role.class, role);
Line 41: if (!role.isSetId()) {
Line 42: org.ovirt.engine.core.common.businessentities.Role entity
= getEntity(org.ovirt.engine.core.common.businessentities.Role.class,
Line 43:
VdcQueryType.GetRoleByName,
Line 44:
new MultilevelAdministrationByRoleNameParameters(role.getName()),
role.getName());
I would suggest to reformat this code to avoid such long lines, something like
this:
org.ovirt.engine.core.common.businessentities.Role entity = getEntity(
org.ovirt.engine.businessentities.Role.class,
VdcQueryType.GetRoleByName,
new MultilevelAdministrationByRoleNameParameters(...)
);
Line 45: role.setId(entity.getId().toString());
Line 46: }
Line 47: return performCreation(VdcActionType.AddSystemPermission,
Line 48: new
PermissionsOperationsParametes(newPermission(role.getId())),
--
To view, visit http://gerrit.ovirt.org/7229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca1616161e2d1bbf3eae5d440fdf8209cafea34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
