Greg Sheremeta has posted comments on this change. Change subject: webadmin: Fix System tree when in Gluster-only mode ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/39363/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java: Line 74: } Line 75: Line 76: for (SystemTreeItemModel systemTreeItemModel : list) { Line 77: systemItem.getChildren().remove(systemTreeItemModel); Line 78: if(systemTreeItemModel.getChildren() != null && !systemItem.getChildren().containsAll(systemTreeItemModel.getChildren())) { How are we making sure this happens in Gluster-only mode? Sorry -- not too familiar with this code. Line 79: systemItem.getChildren().addAll(systemTreeItemModel.getChildren()); Line 80: } Line 81: } Line 82: return !((systemItem.getApplicationMode().getValue() & getUiMode().getValue()) > 0); -- To view, visit https://gerrit.ovirt.org/39363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c85bc2b78f885511a8e53212984d93343ffd6a8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
