Vinzenz Feenstra has posted comments on this change.

Change subject: Support for timezone reporting
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/28013/8/ovirt-guest-agent/timezone.py
File ovirt-guest-agent/timezone.py:

Line 41: 
Line 42: 
Line 43: def _read_etc_timezone():
Line 44:     f = open('/etc/timezone', 'r')
Line 45:     result = f.read().strip()
> (sorry if already asked, but a quick glance on review history wasn't helpfu
I'll put it into a try/except block
Line 46:     f.close()
Line 47:     return result
Line 48: 
Line 49: 


Line 48: 
Line 49: 
Line 50: def _parse_etc_sysconfig_clock():
Line 51:     f = open('/etc/sysconfig/clock', 'r')
Line 52:     data = f.read().split('\n')
> same as above
Same
Line 53:     f.close()
Line 54:     for line in data:
Line 55:         kv = line.split('=')
Line 56:         if len(kv) == 2 and kv[0] == 'ZONE':


-- 
To view, visit https://gerrit.ovirt.org/28013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94c1429f40448a262d0d72fcc6dba2b4b59340c2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to