Dhandapani Gopal has posted comments on this change.

Change subject: engine: Get Gluster Servers query
......................................................................


Patch Set 14: (1 inline comment)

Incorporated review comments.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 106:     protected void validateFingerprint(SSHClient client, String 
fingerprint) {
Line 107:         if (!fingerprint.equals(getFingerprint(client))) {
Line 108:             throw new AccessControlException(String.format("SSH 
Fingerprint of server "
Line 109:                     + getParameters().getServerName()
Line 110:                     + " did not match expected fingerprint " + 
fingerprint));
Sorry, I corrected the String.format error. Also, added the serverName as the 
function argument instead getParameters.
Line 111:         }
Line 112:     }
Line 113: 
Line 114:     // This is required for mock during Junit test


--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to