Yair Zaslavsky has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceId.java
Line 87: this.vmId = vmId;
Line 88: }
Line 89:
Line 90: @Override
Line 91: public int compareTo(VmDeviceId rhs) {
s/rhs/other
Line 92: int vmComparsion = getVmId().compareTo(rhs.getVmId());
Line 93: if (vmComparsion == 0) {
Line 94: return getDeviceId().compareTo(rhs.getDeviceId());
Line 95: } else {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
Line 302: return sb.toString();
Line 303: }
Line 304:
Line 305: @Override
Line 306: public int compareTo(VmDevice rhs) {
Should be changed to "other" as well
Line 307: return getId().compareTo(rhs.getId());
Line 308: }
--
To view, visit http://gerrit.ovirt.org/7989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic82521368a4f3c3c518c8cf4e5dc460b9e54f379
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
