Martin Betak has posted comments on this change. Change subject: frontend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/33376/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java: Line 11: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; Line 12: import org.ovirt.engine.ui.uicompat.UIMessages; Line 13: import org.ovirt.engine.ui.uicompat.external.StringUtils; Line 14: Line 15: public class VmGuestInfoModel extends EntityModel { Please use generics here. EntityModel<VM> Line 16: Line 17: private final static UIMessages messages = ConstantsManager.getInstance().getMessages(); Line 18: private String guestUserName; Line 19: private OsType guestOsType; Line 53: @Override Line 54: protected void onEntityChanged() { Line 55: super.onEntityChanged(); Line 56: Line 57: if (getEntity() != null) Please use the standard java convention of putting the open brace on the same line. Line 58: { Line 59: updateProperties(); Line 60: } Line 61: } Line 71: return clientIp; Line 72: } Line 73: Line 74: public void setClientIp(String clientIp) { Line 75: if (!ObjectUtils.objectsEqual(clientIp, clientIp)) '{' on same line Line 76: { Line 77: this.clientIp = clientIp; Line 78: onPropertyChanged(new PropertyChangedEventArgs("ClientIp")); //$NON-NLS-1$ Line 79: } Line 83: return consoleUserName; Line 84: } Line 85: Line 86: public void setConsoleUserName(String consoleUserName) { Line 87: if (!ObjectUtils.objectsEqual(consoleUserName, consoleUserName)) '{' on same line Line 88: { Line 89: this.consoleUserName = consoleUserName; Line 90: onPropertyChanged(new PropertyChangedEventArgs("ConsoleUserName")); //$NON-NLS-1$ Line 91: } Line 93: Line 94: Line 95: Line 96: private void updateProperties() { Line 97: VM vm = (VM) getEntity(); this cast will become redundant with the EntityModel<VM> change. Line 98: Line 99: setClientIp(vm.getClientIp()); Line 100: setConsoleUserName(vm.getConsoleCurentUserName()); Line 101: setGuestUserName(vm.getGuestCurentUserName()); -- To view, visit https://gerrit.ovirt.org/33376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f9ae95b2b9fe9affa27886a7981bcdffabee49 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
