Francesco Romani has posted comments on this change.

Change subject: core, engine: servlet to support the console proxy
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/35887/4/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ConsoleProxyServlet.java
File 
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ConsoleProxyServlet.java:

Line 49:             List<UserProfile> users = v.getReturnValue();
Line 50: 
Line 51:             for (UserProfile user : users) {
Line 52:                 if (StringUtils.isNotEmpty(user.getSshPublicKey())) {
Line 53:                     jsonUsers.put(user.getId().toString(), 
user.getSshPublicKey());
> I would like to have user name as well for auditing purposes
Done (not sure yet about the implementation)
Line 54:                 }
Line 55:             }
Line 56:         }
Line 57: 


-- 
To view, visit https://gerrit.ovirt.org/35887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c721da21cefcf4069d14c7016b6f7d97f9eac9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to