Ori Liel has uploaded a new change for review.

Change subject: engine: Double Notification Received (#1192528)
......................................................................

engine: Double Notification Received (#1192528)

When a Highly-Available VM goes down with an error,
the engine attempts to re-run it. If the first attempt
fails, the engine immediately attempts once more.

Subscribers which subscribed to the notification:
"VDS_INITIATED_RUN_VM_FAILED" receive notification about
both events, even though they are milliseconds apart
and one notification should be enough.

This bug was solved by setting a 'flood limit' of 5
seconds on this event.

Change-Id: Ib97d2e7f456f13331f843591716f280b9f17d1ca
Signed-off-by: Ori Liel <[email protected]>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/39552/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
index d4856be..7ef1e7b 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
@@ -58,7 +58,7 @@
     VDS_INSTALL_FAILED(505, AuditLogSeverity.ERROR),
     VDS_INITIATED_RUN_VM(506),
     VDS_INITIATED_RUN_VM_AS_STATELESS(537),
-    VDS_INITIATED_RUN_VM_FAILED(507, AuditLogSeverity.ERROR),
+    VDS_INITIATED_RUN_VM_FAILED(507, AuditLogSeverity.ERROR, 
AuditLogTimeInterval.SECOND.getValue() * 5),
     VDS_INITIATED_RUN_AS_STATELESS_VM_NOT_YET_RUNNING(525),
     // VDS_INITIATED_RUN_VM_CHECKOUT_FAILED = 508,
     VDS_INSTALL_IN_PROGRESS(509),


-- 
To view, visit https://gerrit.ovirt.org/39552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib97d2e7f456f13331f843591716f280b9f17d1ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to