Moti Asayag has posted comments on this change. Change subject: engine: introduce UpdateHostNicVfsConfigCommand ......................................................................
Patch Set 11: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/36843/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfsConfigCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfsConfigCommandBase.java: Line 34: && validate(getVfsConfigValidator().nicSriovEnabled()) Line 35: && validate(getVfsConfigValidator().sriovFeatureSupported()); Line 36: } Line 37: Line 38: public InterfaceDao getInterfaceDao() { now with injectable dao patch is merged, you should replace those getXXXDao() methods with @Inject private XXXdao xxxDao; Line 39: return getDbFacade().getInterfaceDao(); Line 40: } Line 41: Line 42: public HostNicVfsConfigDao getVfsConfigDao() { https://gerrit.ovirt.org/#/c/36843/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VfsConfigBaseParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VfsConfigBaseParameters.java: Line 3: import javax.validation.constraints.NotNull; Line 4: Line 5: import org.ovirt.engine.core.compat.Guid; Line 6: Line 7: public abstract class VfsConfigBaseParameters extends VdsActionParameters { why do you need it to extend from VdsActionParameters ? there is no use of the hostId here... Line 8: Line 9: private static final long serialVersionUID = 8442994960202140298L; Line 10: Line 11: @NotNull https://gerrit.ovirt.org/#/c/36843/11/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 560: UPDATE_VNIC_PROFILE=VM network interface profile ${VnicProfileName} was updated for network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 561: UPDATE_VNIC_PROFILE_FAILED=Failed to update VM network interface profile ${VnicProfileName} for network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 562: REMOVE_VNIC_PROFILE=VM network interface profile ${VnicProfileName} was removed from network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 563: REMOVE_VNIC_PROFILE_FAILED=Failed to remove VM network interface profile ${VnicProfileName} from network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 564: UPDATE_HOST_NIC_VFS_CONFIG=The VFs configuration of network interface card ${NicName} was updated. this isn't enough to identify the change. Assume 10 hosts in the system with 'eth1'. The message will not describe the modified host. Please add the host name as well. Line 565: UPDATE_HOST_NIC_VFS_CONFIG_FAILED=Failed to update the VFs configuration of network interface card ${NicName}. Line 566: SYSTEM_DEACTIVATED_STORAGE_DOMAIN=Storage Domain ${StorageDomainName} (Data Center ${StoragePoolName}) was deactivated by system because it's not visible by any of the hosts. Line 567: SYSTEM_DEACTIVATE_STORAGE_DOMAIN_FAILED=Failed to deactivate Storage Domain ${StorageDomainName} (Data Center ${StoragePoolName}). Line 568: VDS_SET_NONOPERATIONAL_DOMAIN=Host ${VdsName} cannot access the Storage Domain(s) ${StorageDomainNames} attached to the Data Center ${StoragePoolName}. Setting Host state to Non-Operational. Line 561: UPDATE_VNIC_PROFILE_FAILED=Failed to update VM network interface profile ${VnicProfileName} for network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 562: REMOVE_VNIC_PROFILE=VM network interface profile ${VnicProfileName} was removed from network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 563: REMOVE_VNIC_PROFILE_FAILED=Failed to remove VM network interface profile ${VnicProfileName} from network ${NetworkName} in Data Center: ${DataCenterName}. (User: ${UserName}) Line 564: UPDATE_HOST_NIC_VFS_CONFIG=The VFs configuration of network interface card ${NicName} was updated. Line 565: UPDATE_HOST_NIC_VFS_CONFIG_FAILED=Failed to update the VFs configuration of network interface card ${NicName}. same here Line 566: SYSTEM_DEACTIVATED_STORAGE_DOMAIN=Storage Domain ${StorageDomainName} (Data Center ${StoragePoolName}) was deactivated by system because it's not visible by any of the hosts. Line 567: SYSTEM_DEACTIVATE_STORAGE_DOMAIN_FAILED=Failed to deactivate Storage Domain ${StorageDomainName} (Data Center ${StoragePoolName}). Line 568: VDS_SET_NONOPERATIONAL_DOMAIN=Host ${VdsName} cannot access the Storage Domain(s) ${StorageDomainNames} attached to the Data Center ${StoragePoolName}. Setting Host state to Non-Operational. Line 569: VDS_SET_NONOPERATIONAL_DOMAIN_FAILED=Host ${VdsName} cannot access the Storage Domain(s) ${StorageDomainNames} attached to the Data Center ${StoragePoolName}. Failed to set Host state to Non-Operational. https://gerrit.ovirt.org/#/c/36843/11/backend/manager/modules/uutils/abrt_checker_7074.log File backend/manager/modules/uutils/abrt_checker_7074.log: please remove the file from this patch. Line 1: Uncaught java.lang.ClassNotFoundException exception in thread "main" in a method java.lang.ClassLoader.loadClass() with signature (Ljava/lang/String;Z)Ljava/lang/Class; Line 2: Exception in thread "main" java.lang.ClassNotFoundException: .home.alkaplan.dev.git.ovirt-engine.backend.manager.modules.uutils.target.surefire.surefirebooter4401271232154842871.jar Line 3: at java.net.URLClassLoader$1.run(URLClassLoader.java:366) [jar:file:/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.71-2.5.3.0.fc20.x86_64/jre/lib/rt.jar!/java/net/URLClassLoader$1.class] Line 4: at java.net.URLClassLoader$1.run(URLClassLoader.java:355) [jar:file:/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.71-2.5.3.0.fc20.x86_64/jre/lib/rt.jar!/java/net/URLClassLoader$1.class] -- To view, visit https://gerrit.ovirt.org/36843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I868d58b291c3920f6cf966a409a11a06498854b1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
