Juan Hernandez has posted comments on this change. Change subject: restapi: add OpenStackVolumeTypes sub-collection ......................................................................
Patch Set 1: Code-Review+2 (4 comments) Some minor comments that you may want to address before merging. https://gerrit.ovirt.org/#/c/39371/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 5372: </xs:sequence> Line 5373: </xs:extension> Line 5374: </xs:complexContent> Line 5375: </xs:complexType> Line 5376: Remember to remove this before merging. Line 5377: <xs:element name="openstack_volume_type" type="OpenStackVolumeType"/> Line 5378: Line 5379: <xs:element name="openstack_volume_types" type="OpenStackVolumeTypes"/> Line 5380: https://gerrit.ovirt.org/#/c/39371/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 6175: parameterType: null Line 6176: signatures: [] Line 6177: urlparams: Line 6178: max: {context: matrix, type: 'xs:int', value: 'max results', required: false} Line 6179: headers: {} Don't included this empty "headers" element. Line 6180: - name: /openstackvolumeproviders/{openstackvolumeprovider:id}/volumetypes/{volumetype:id}|rel=get Line 6181: description: get the details of the specified volume type of the OpenStack volume provider Line 6182: request: Line 6183: body: Line 6183: body: Line 6184: parameterType: null Line 6185: signatures: [] Line 6186: urlparams: {} Line 6187: headers: {} Don't include the empty "headers" and "urlparams" elements. Line 6188: Line 6189: - name: /openstacknetworkproviders|rel=get Line 6190: description: get the list of all OpenStack network providers in the system Line 6191: request: https://gerrit.ovirt.org/#/c/39371/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackStorageProviderHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackStorageProviderHelper.java: Line 28: image Consider renaming in the javadoc as well. -- To view, visit https://gerrit.ovirt.org/39371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08157edb4f4808880848bc9f7d07c29500d1197d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
