Ori Liel has uploaded a new change for review.

Change subject: events: Refine Host Activation Message (#1193060)
......................................................................

events: Refine Host Activation Message (#1193060)

When user activates a host, ActivateVdsCommand doesn't
perform the actual activation; it only changes the host
status. The host is activated later asynchronously.

When the command terminates it audits:
Host X activated by user Y.

This is not true, and if some error prvents the actual
activation, the audit log is confusing. So the auditing
was changed to:

Activation of host X initiated by user Y.

Bug-Url: http://bugzilla.redhat.com/1193060
Change-Id: I698dac3797c957ed3dabe33490482e334d9d27d8
Signed-off-by: Ori Liel <[email protected]>
---
M 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/39578/1

diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
index 230c342..f1fece5 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
@@ -231,7 +231,7 @@
 VDS_MANUAL_FENCE_FAILED_CALL_FENCE_SPM=Manual fence did not revoke the 
selected SPM (${VdsName}) since the master storage domain\n was not active or 
could not use another host for the fence operation.
 VDC_START=Starting oVirt Engine.
 VDC_STOP=Stopping oVirt Engine.
-VDS_ACTIVATE=Host ${VdsName} was activated by ${UserName}.
+VDS_ACTIVATE=Activation of host ${VdsName} initiated by ${UserName}.
 VDS_ACTIVATE_ASYNC=Host ${VdsName} was autorecovered.
 VDS_ACTIVATE_MANUAL_HA=Host ${VdsName} was activated by ${UserName}, but the 
Hosted Engine HA service may still be in maintenance mode. If necessary, please 
correct this manually.
 VDS_ACTIVATE_MANUAL_HA_ASYNC=Host ${VdsName} was autorecovered, but the Hosted 
Engine HA service may still be in maintenance mode. If necessary, please 
correct this manually.


-- 
To view, visit https://gerrit.ovirt.org/39578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I698dac3797c957ed3dabe33490482e334d9d27d8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to