Alona Kaplan has uploaded a new change for review. Change subject: engine: OvfReader- use VmInterfaceType.forValue() instead of for loop ......................................................................
engine: OvfReader- use VmInterfaceType.forValue() instead of for loop The fix done accrding to comment- https://gerrit.ovirt.org/#/c/38260/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java Change-Id: Ifccc08fe7cf5ed64900a54013b1e616a59c44611 Signed-off-by: Alona Kaplan <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 4 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/39590/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java index 1ae296d..8e192fe 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java @@ -902,15 +902,10 @@ } } else if (Integer.valueOf(OvfHardware.Network) == resourceType) { // handle interfaces with different sub types : we have 0-3 as the VmInterfaceType enum - boolean isKnownType = false; - for (VmInterfaceType vmInterfaceType : VmInterfaceType.values()) { - if (Integer.valueOf(vmInterfaceType.getValue()) == resourceSubType) { - vmDevice.setDevice(VmDeviceType.BRIDGE.getName()); - isKnownType = true; - break; - } - } - if (!isKnownType) { + VmInterfaceType nicType = VmInterfaceType.forValue(resourceSubType); + if (nicType != null) { + vmDevice.setDevice(VmDeviceType.BRIDGE.getName()); + } else { vmDevice.setDevice(VmDeviceType.getoVirtDevice(resourceType).getName()); } } -- To view, visit https://gerrit.ovirt.org/39590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifccc08fe7cf5ed64900a54013b1e616a59c44611 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
