Oved Ourfali has posted comments on this change. Change subject: webadmin: cluster general subtab: show virt/gluster service status ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39585/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java: Line 87: formBuilder.addFormItem(new FormItem(constants.descriptionCluster(), description, 1, 0)); Line 88: formBuilder.addFormItem(new FormItem(constants.dcCluster(), dataCenterName, 2, 0, virtSupported)); Line 89: formBuilder.addFormItem(new FormItem(constants.compatibilityVersionCluster(), compatibilityVersion, 3, 0)); Line 90: formBuilder.addFormItem(new FormItem(constants.glusterSupported(), glusterEnabled, 4, 0)); Line 91: formBuilder.addFormItem(new FormItem(constants.virtSupported(), virtEnabled, 5, 0)); Seems good to me. I wonder, however, what's the meaning of "AllModes" in the ApplicationMode enum... Line 92: Line 93: // Show the cluster type only if the application is running in both the modes Line 94: formBuilder.addFormItem(new FormItem(constants.clusterType(), clusterType, 6, 0, virtSupported Line 95: && glusterSupported)); -- To view, visit https://gerrit.ovirt.org/39585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8557e466fc5929607746f0640d51d5b386895a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
