Einav Cohen has posted comments on this change. Change subject: webadmin: Fix System tree when in Gluster-only mode ......................................................................
Patch Set 7: Thanks Anmol and Greg. > I believe that in 'both' mode, Datacenter will show up and look normal Based on the latest screen-shots from Anmol, I think that Greg is right. The point that I missed is that there can't be a "mixed" mode in the tree (i.e. a mode in which there is a "Clusters" root node *as well as* a "Data-Centers" root node in the tree): - In 'Gluster-Only' ApplicationMode: There aren't any (meaningful) Data-Centers, we only have gluster-only Clusters, hence the tree will contain only the 'Clusters' root node. - In any other ApplicationMode: *Every* Cluster, even a gluster-only Cluster, must belong to a Data-Center. Therefore, we will not have in the tree a 'Clusters' root node at all - only a 'Data-Centers' root node, and all of the Clusters will appear beneath their relevant Data-Center node. So since there is no "mixed" mode in the tree, my concern regarding having a Cluster appearing potentially twice within the tree or anything like that is irrelevant. Bottom line: Looks OK on my end. @Greg/Anmol - please correct me if I was wrong in any of the assumptions that I made above and/or share any additional questions/comments that you have. Thanks. -- To view, visit https://gerrit.ovirt.org/39363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c85bc2b78f885511a8e53212984d93343ffd6a8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
