Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/38547/20/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 100: ], Line 101: ) Line 102: def _closeup(self): Line 103: if os.path.exists(odeploycons.FileLocations.HOSTED_ENGINE_CONF): Line 104: os.unlink(odeploycons.FileLocations.HOSTED_ENGINE_CONF) > this is not a good design, it should look at content not existence, please I'll open a BZ on that, until that will be fixed, let's keep behavior consistent and let's remove the config file. I'll drop this once vdsm will be fixed. Line 105: Line 106: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
