Ramesh N has posted comments on this change. Change subject: webadmin : Import cluster bug ......................................................................
Patch Set 1: (8 comments) https://gerrit.ovirt.org/#/c/35864/1//COMMIT_MSG Commit Message: Line 4: Commit: Anmol Babu <[email protected]> Line 5: CommitDate: 2014-12-04 12:05:46 +0530 Line 6: Line 7: webadmin : Import cluster bug Line 8: Please add some detail regarding the fix and the bug so that it will be easy to understand the patch Line 9: Import cluster bug Line 10: Line 11: Change-Id: I6ef25918d18f6e6544622369a42affa365538ee4 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1103459 https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1703: isAllCanDoPassed this will be true always. So this can be removed from the check. Line 2008: if (host.getValue() == null || host.getValue().equals("")) StringUtils.isEmpty() can be used here https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java: Line 1409: cancel(); : postAction(); remove this change Line 1689: //updateOptions(); why are u commenting this method? https://gerrit.ovirt.org/#/c/35864/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 638: importClusterHosts How this method is different from ClusterListModel.importClusterHosts Line 640: addMultipleHostsCommand.execute(); Where this being handled? Line 1082: onSaveHosts This also similar to what is being done in ClusterListModel.onSaveHosts() -- To view, visit https://gerrit.ovirt.org/35864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ef25918d18f6e6544622369a42affa365538ee4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
