Lior Vernia has posted comments on this change. Change subject: webadmin: fluent UiAction ......................................................................
Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/36848/19/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiAction.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiAction.java: Line 98: * Line 99: * @param actionFlowState Line 100: * the state of the flow this action wants to join. Line 101: */ Line 102: public void runAction(ActionFlowState actionFlowState) { > I want the actions within vfsConfigAction to run only if (and after) the Co Then I'm sorry, I still don't understand why there's any need to pass the state. State (as it's currently implemented) only needs to be passed around when there are parallel actions running. And this should only happen from another action. If you want an action to comprise a flow of actions within it, then no problem - within its execution it should construct another flow and run that, and only return when that flow finishes (e.g. trigger its own nextAction from/as the internal flow's finalAction). As I understand it, your problem with the vfsConfigAction flow is that it's an asynchronous flow and you're trying to run it as a synchronous flow - I don't think SyncUiAction should be used in such a case. Line 103: actionFlowState.setValue(actionFlowState.getValue() + 1); Line 104: runActionNoStateIncrease(actionFlowState); Line 105: } Line 106: -- To view, visit https://gerrit.ovirt.org/36848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I262282d00bbb16a65f36a2463d3ffe8dbf6594c6 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
