Eli Mesika has posted comments on this change. Change subject: core: [RFE]Backup Awareness - Handler ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39527/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java: Line 25: @Singleton Line 26: public class EngineBackupAwarenessManager { Line 27: private static final Logger log = LoggerFactory.getLogger(EngineBackupAwarenessManager.class); Line 28: private boolean active = false; Line 29: private static final String DB = "engine"; > i don't think hard-coding the db engine name is a good practice. Sorry, that's not the point The point is that only one backup is available for the engine (and maybe one for dwh in future), so , the name identifying the engine backup is 'engine' no matter what the real DB name is As I noted, we have no RFE to support more than one engine DB per installation so I think this fully covers the RFE and backing up according to the real DB name will add nothing to this feature functionality Line 30: Line 31: @Inject Line 32: private AuditLogDirector auditLogDirector; Line 33: -- To view, visit https://gerrit.ovirt.org/39527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8567ae314a3d612d8e3d4dd948394b65789ac670 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
