Martin Peřina has posted comments on this change. Change subject: core: Refactor FenceProxyLocator ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39764/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java: Line 63: > I wonder why the try-catch clause was written here in the first place, can This try block with exception logging is already part of ThreadUtils.sleep() method. Line 210: return new VdsFenceOptions(version); Line 211: } Line 212: Line 213: // TODO Investigate if injection is possible Line 214: protected DbFacade getDbFacade() { > why not ? Well, it's a bit problematic, because FenceProxyLocator (and all other fence executor classes) are not managed beans (so AFAIK we cannot inject anything into them). And for now it doesn't make sense for me how they can be changed to managed beans, because they are created as needed inside fencing flow and not created by bean manager. I'm planning to investigate this more when we move to WildFly with newer Weld. Line 215: return DbFacade.getInstance(); Line 216: } -- To view, visit https://gerrit.ovirt.org/39764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59d5b46273dbaeb2d73142f1256000e36a6cbdd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
