Alon Bar-Lev has posted comments on this change.

Change subject: pki: add pki-enroll-openssh-cert functionality
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38094/3/packaging/bin/pki-enroll-openssh-cert.sh
File packaging/bin/pki-enroll-openssh-cert.sh:

Line 14: 
Line 15:        common_backup "${sshpub}" "${sshcert}"
Line 16: 
Line 17:        #
Line 18:        # TODO: replace when el-6 supports -m PKCS8
> I don't think we have to support el6 anymore
really?

this means we need to migrate all our developers as well...
Line 19:        #
Line 20:        openssl x509 -in "${cert}" -noout -pubkey | \
Line 21:                "${BINDIR}/pki-ssh-keygen.py" -i -m PKCS8 -f 
/proc/self/fd/0 \
Line 22:                > "${sshpub}" \


-- 
To view, visit https://gerrit.ovirt.org/38094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide34d4f0ffadf70e6ce42ae57328e262a832a3e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to