Piotr Kliczewski has posted comments on this change.

Change subject: events: make event processing pool size configurable
......................................................................


Patch Set 7:

(2 comments)

Will update engine-config.properties as well.

https://gerrit.ovirt.org/#/c/39093/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java:

Line 76:             throw new IllegalStateException(e);
Line 77:         }
Line 78:     }
Line 79: 
Line 80:     private static JsonRpcClient getJsonClient(Reactor reactor, String 
hostName, int port, ClientPolicy
> please use formatter.
Done
Line 81:             connectionPolicy, ClientPolicy clientPolicy, int 
parallelism) throws ClientConnectionException {
Line 82:         final ReactorClient client = reactor.createClient(hostName, 
port);
Line 83:         client.setClientPolicy(connectionPolicy);
Line 84:         ResponseWorker worker = ReactorFactory.getWorker(parallelism);


https://gerrit.ovirt.org/#/c/39093/7/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java
File 
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java:

Line 29: 
Line 30:     @Test
Line 31:     public void testGetVdsCapabilities() throws InterruptedException, 
ExecutionException, ClientConnectionException {
Line 32:         JsonRpcClient client = 
JsonRpcUtils.createStompClient(HOST_ADDRESS, PORT, TIMEOUT, 0, TIMEOUT, 
TIMEOUT, true, "TLSv1",
Line 33:                 Runtime.getRuntime().availableProcessors(), 
DEFAULT_REQUEST_QUEUE, DEFAULT_RESPONSE_QUEUE);
> please use formatter.
Done
Line 34:         final JsonRpcRequest request = new 
RequestBuilder("Host.getCapabilities").build();
Line 35:         Map<String, Object> map = new FutureMap(client, request);
Line 36:         assertTrue(map.isEmpty());
Line 37:     }


-- 
To view, visit https://gerrit.ovirt.org/39093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4e71d1767180bb22fc8129ccec9ed967cf4a8ad
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to