Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: SanStorageLunToTargetList FindBugs
......................................................................
webadmin: SanStorageLunToTargetList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE.
The items variable is clearly not null here, since isEmpty() is called
on it beforehand, so the conditional statement can be safely removed.
Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/76/8176/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
index a965440..631e11a 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
@@ -290,7 +290,7 @@
return null;
}
- table.setRowData(items == null ? new ArrayList<SanTargetModel>() :
items);
+ table.setRowData(items);
table.edit(leafModel);
table.setWidth("100%", true); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/8176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
