Sandro Bonazzola has posted comments on this change. Change subject: support .repo overrides ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/39534/13/ovirt-release-master/configure.ac File ovirt-release-master/configure.ac: Line 36: AC_ARG_WITH([ovirt-version],[AC_HELP_STRING([--with-ovirt-version], Line 37: [Specify ovirt-version. Defaults to 3.6.0])], Line 38: [OVIRT_VERSION="$withval"], Line 39: [OVIRT_VERSION="3.6.0"]) Line 40: AC_SUBST([OVIRT_VERSION]) Looks like you need OVIRT_VERSION for telling the spec file to run configure with specified OVIRT_VERSION and you never use it. for anything else. I think you can just drop it from here and from the spec file. Line 41: Line 42: AC_ARG_WITH([ovirt-yum-repo],[AC_HELP_STRING([--with-ovirt-yum-repo], Line 43: [Specify yum repo, defaults to: http://resources.ovirt.org/])], Line 44: [OVIRT_YUM_REPO="$withval"], -- To view, visit https://gerrit.ovirt.org/39534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0453fb472d80a190278a0ffbae4371ad724b4c46 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: Barak Korren <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
