Ramesh N has posted comments on this change.

Change subject: engine : Entity and DAO changes for Disk provisioning
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39704/2/packaging/dbscripts/upgrade/03_05_1360_add_storage_device_tables.sql
File packaging/dbscripts/upgrade/03_05_1360_add_storage_device_tables.sql:

Line 1: -- Add storage_device table
Line 2: CREATE TABLE storage_device
Line 3: (
Line 4:     id UUID NOT NULL,
Line 5:     name VARCHAR(1000) NOT NULL,
> I prefer text here
This patch is already merged in master. Do we need to send another patch to 
master to correct it.
Line 6:     device_uuid VARCHAR(38),
Line 7:     filesystem_uuid VARCHAR(38),
Line 8:     vds_id UUID NOT NULL,
Line 9:     description VARCHAR(2000),


-- 
To view, visit https://gerrit.ovirt.org/39704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to