Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 134: public Object syncObj = new Object();
Line 135:
Line 136: public static final String UpVdssInStoragePoolQuery =
"STORAGE: status = UP and DATACENTER = {0}";
Line 137: private final String storagePoolRefreshJobId;
Line 138: private final HashSet<Guid> mTriedVdssList = new
HashSet<Guid>();
can't the variable be defined as a Set?
Line 139: private Guid mCurrentVdsId;
Line 140:
Line 141: public Guid getCurrentVdsId() {
Line 142: return getIrsProxy() != null ? mCurrentVdsId : Guid.Empty;
Line 255: // if spm status didnt work or not spm and NOT
NETWORK
Line 256: // PROBLEM
Line 257: // then cause failover with attempts
Line 258: if (result != null &&
!(result.getExceptionObject() instanceof VDSNetworkException)) {
Line 259: HashMap<Guid, AsyncTaskStatus> tasksList =
can't taksList be defined as a Map?
Line 260: (HashMap<Guid, AsyncTaskStatus>)
ResourceManager
Line 261: .getInstance()
Line 262:
.runVdsCommand(VDSCommandType.HSMGetAllTasksStatuses,
Line 263: new
VdsIdVDSCommandParametersBase(mCurrentVdsId)).getReturnValue();
--
To view, visit http://gerrit.ovirt.org/7960
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba1e15e149d3121b6774b635d85b3ca5f227ba0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
