Allon Mureinik has posted comments on this change.
Change subject: core: IrsBrokerCommand cleanup II
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
see inline
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1040:
Line 1041: private final Map<Guid, HashSet<Guid>> _vdssInProblem = new
HashMap<Guid, HashSet<Guid>>();
Line 1042: private final Map<Guid, HashSet<Guid>> _domainsInProblem =
new ConcurrentHashMap<Guid, HashSet<Guid>>();
Line 1043: private final Map<Guid, String> _timers = new HashMap<Guid,
String>();
Line 1044: private final AtomicBoolean duringReconstructMaster = new
AtomicBoolean(false);
how is this related to the change?
Line 1045: private final Object _lockObject = new Object();
Line 1046: private final ReentrantLock _lockObjForDbSave = new
ReentrantLock();
Line 1047:
Line 1048: public void lockDbSave() {
Line 1058: public void UpdateVdsDomainsData(final Guid vdsId, final
String vdsName,
Line 1059: final ArrayList<VDSDomainsData> data) {
Line 1060:
Line 1061: Set<Guid> domainsInProblems =
Line 1062:
TransactionSupport.executeInScope(TransactionScopeOption.Suppress,
Good change, but I think it's unrelated to this patch?
Line 1063: new TransactionMethod<Set<Guid>>() {
Line 1064: @Override
Line 1065: public Set<Guid> runInTransaction() {
Line 1066:
--
To view, visit http://gerrit.ovirt.org/7961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c540b180d4b126b43c783e8780edb01fb49dde
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
