Daniel Erez has uploaded a new change for review. Change subject: core: handle negative flow for add cinder disk ......................................................................
core: handle negative flow for add cinder disk Set TaskGroupSuccess to false to ensure endWithFailure is called. Change-Id: Ieb678ba506a134650b12125098c4fb3f2a084a7f Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/39859/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java index 844537d..278d8fb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java @@ -37,6 +37,7 @@ super.onFailed(cmdId, childCmdIds); log.error("Failed adding disk to Cinder. ID: {}", getDiskId()); + getCommand().getParameters().setTaskGroupSuccess(false); getCommand().endAction(); CommandCoordinatorUtil.removeAllCommandsInHierarchy(cmdId); } -- To view, visit https://gerrit.ovirt.org/39859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb678ba506a134650b12125098c4fb3f2a084a7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
