Amit Aviram has uploaded a new change for review. Change subject: core: QuotaStorageDependent removal in ExtendImageSizeCommand. ......................................................................
core: QuotaStorageDependent removal in ExtendImageSizeCommand. ExtendImageSizeCommand currently implements QuotaStorageDependent which deals with quota consumptions. The command is being called in UpdateVmDiskCommand in case the disk size is extended, but never reaches the actual consume part in the code as it is constructed as an unquota-dependent command. Moreover, UpdateDiskCommand deals with any case of quota consumption so dealing with that is not needed in that command. Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc Signed-off-by: Amit Aviram <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java 1 file changed, 1 insertion(+), 23 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/39866/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java index 5740858..94d0e81 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java @@ -5,9 +5,6 @@ import java.util.List; import org.ovirt.engine.core.bll.context.CommandContext; -import org.ovirt.engine.core.bll.quota.QuotaConsumptionParameter; -import org.ovirt.engine.core.bll.quota.QuotaStorageConsumptionParameter; -import org.ovirt.engine.core.bll.quota.QuotaStorageDependent; import org.ovirt.engine.core.bll.utils.PermissionSubject; import org.ovirt.engine.core.common.AuditLogType; import org.ovirt.engine.core.common.VdcObjectType; @@ -29,8 +26,7 @@ @InternalCommandAttribute @NonTransactiveCommandAttribute -public class ExtendImageSizeCommand<T extends ExtendImageSizeParameters> extends BaseImagesCommand<T> - implements QuotaStorageDependent { +public class ExtendImageSizeCommand<T extends ExtendImageSizeParameters> extends BaseImagesCommand<T> { private List<PermissionSubject> permissionsList; private List<VM> vmsDiskPluggedTo; @@ -170,24 +166,6 @@ } return permissionsList; - } - - @Override - public List<QuotaConsumptionParameter> getQuotaStorageConsumptionParameters() { - List<QuotaConsumptionParameter> params = new ArrayList<QuotaConsumptionParameter>(); - if (getImage() != null) { - double newSizeInGigabytes = Long.valueOf(getParameters().getNewSize() / BYTES_IN_GB).doubleValue(); - double currentSizeInGigabytes = Long.valueOf(getImage().getSizeInGigabytes()).doubleValue(); - double additionalDiskSpace = newSizeInGigabytes - currentSizeInGigabytes; - - params.add(new QuotaStorageConsumptionParameter( - getImage().getQuotaId(), - null, - QuotaConsumptionParameter.QuotaAction.CONSUME, - getParameters().getStorageDomainId(), - additionalDiskSpace)); - } - return params; } @Override -- To view, visit https://gerrit.ovirt.org/39866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
