Sharad Mishra has posted comments on this change. Change subject: core: ChangeDiskCommand clenaup ......................................................................
Patch Set 1: Looks good to me, but someone else must approve I personally like the use of StringHelper in this case as it makes the code more readable. But I can go with the change as it seems more efficient. -- To view, visit http://gerrit.ovirt.org/8203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1173561fe3dc44d7f4d7951d5772440ac7601fd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
